Fix schema registry overview status fallback#2431
Open
peter941221 wants to merge 1 commit intoredpanda-data:masterfrom
Open
Fix schema registry overview status fallback#2431peter941221 wants to merge 1 commit intoredpanda-data:masterfrom
peter941221 wants to merge 1 commit intoredpanda-data:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2422.
The Overview page currently conflates three different Schema Registry states into the same
nullvalue:That lets request failures or skipped requests render as
Not configured, even when Schema Registry is configured and working.This patch keeps the change frontend-only and narrows the
Not configuredfallback so it is only shown when the backend explicitly reports feature-not-configured semantics.What changed
schemaRegistryErrorto the overview statecanViewSchemas === falseCode.UnimplementedasNot configurednullUnavailablein the Overview card when the schema-registry overview request failsThis intentionally does not change the existing UX for users whose schema permissions are explicitly denied.
Testing
vitest --config=vitest.config.unit.mts src/state/backend-api.test.tsvitest --config=vitest.config.integration.mts src/components/pages/overview/overview.test.tsx